Add external links to links.json artifact #166
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Mpdreamz suggested a more performant way of doing this. Instead of making the changes in this PR, I will close this and create a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
For our Links Validation Service, we need to generate a list of external links (links pointing to external documentation in our system) that will be uploaded to the Link Index.
Changes
Add external links to the links.json
Resulting JSON file:
{ "origin": { "branch": "feature/add-external-links", "remote": "elastic/docs-builder-unknown", "ref": "03c22a29e6585b72f64a0aa64f087dd5664c939f" }, "url_path_prefix": "", "internal_links": [ "index.md", "configure/index.md", "configure/page.md", "testing/external-links.md", "...", ], "external_links": [ "kibana://path/to/file.md", "kibana://path/to/another/file.md" ] }